A stab at allowing custom datasets #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitryKey is there a way to make this work without failing checks |
maumueller
reviewed
Oct 4, 2021
benchmark/datasets.py
Outdated
| # for dim reduced file of dtype float32 | ||
| n, d = map(int, np.fromfile(fname, dtype="float32", count=2)) | ||
| n = 100000000 | ||
| d = 32 |
There was a problem hiding this comment.
This shouldn't be here. (And it seems the whole xbin_mmap should not be changed at all.
There was a problem hiding this comment.
yes, absolutely -- these had to be hardcoded on my side, because the derived values were not correct. I will remove this.
|
I am closing this in preparation of some bigger changes to the code base that will make this hard to maintain without an actual use-case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #42