Change 'number' to 'int' input on number variations

harness · Jul 7, 2022 · 36b8608 · 36b8608
1 parent 3d83f1a
commit 36b8608
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/evaluation/evaluator.go b/evaluation/evaluator.go
@@ -386,8 +386,8 @@ func (e Evaluator) IntVariation(identifier string, target *Target, defaultValue
 
 // NumberVariation returns number evaluation for target
 func (e Evaluator) NumberVariation(identifier string, target *Target, defaultValue float64) float64 {
-
-	variation, err := e.evaluate(identifier, target, "number")
+	//all numbers are stored as ints in the database
+	variation, err := e.evaluate(identifier, target, "int")
 	if err != nil {
 		e.logger.Errorf("Error while evaluating number flag '%s', err: %v", identifier, err)
 		return defaultValue

diff --git a/evaluation/evaluator_test.go b/evaluation/evaluator_test.go
@@ -136,7 +136,7 @@ var (
 					Variation: &heavyWeight,
 				},
 				Variations: numberVariations,
-				Kind:       "number",
+				Kind:       "int",
 			},
 			org: {
 				Feature: org,
@@ -173,7 +173,7 @@ var (
 						Value:      invalidNumberValue,
 					},
 				},
-				Kind: "number",
+				Kind: "int",
 			},
 			invalidJSON: {
 				Feature: invalidJSON,