Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Server Owner perms are reported wrong #375

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Blocksnmore
Copy link
Contributor

About

This PR makes server owners have all permissions by default as currently checking for items such as admin would return false even though the owner would have it.

Possibly fixes #369? I'm not 100% sure if this is what was meant given my testing seems to show all users correctly other than owner

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Helloyunho Helloyunho merged commit 07d04ea into harmonyland:main Dec 15, 2023
4 checks passed
@Blocksnmore Blocksnmore deleted the fix-owner-perms branch February 10, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Message.Member.Permissions has incorrect permissions set
2 participants