Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix voice state update sometimes not setting the member cache #368

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Fix voice state update sometimes not setting the member cache #368

merged 2 commits into from
Sep 25, 2023

Conversation

Mabi19
Copy link
Contributor

@Mabi19 Mabi19 commented Sep 12, 2023

About

Fixes a bug where voice state update events didn't always set the member cache, leading to the user and member properties on VoiceState objects being missing.

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@Mabi19
Copy link
Contributor Author

Mabi19 commented Sep 20, 2023

I probably ran Prettier wrong, I'll try to fix the formatting in a few hours

@Mabi19
Remove rogue whitespace
91517bc 
I forgot to enable the whitespace trimming option on my new PC :(
Helloyunho
Helloyunho approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Helloyunho Helloyunho merged commit 80b3317 into harmonyland:main Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mabi19 @Helloyunho