Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 7 #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Task 7 #38

wants to merge 2 commits into from

Conversation

Yorickov
Copy link

@Yorickov Yorickov commented May 1, 2023

No description provided.

spajic
spajic approved these changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@spajic spajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё так, отличная работа!

case-study-template.md
Вот тут более показательно - достаточно обойти все спеки и поставить let_it_be для user (в меньшей степени для article) чтобы получить значимый прирост.
'let_it_be(:user)' в spec/models/article_spec.rb выиграл пару секунд

На этом остановимся. Итог: 149 sec. - прогресс неплохой по сравнению с 9 мин.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spajic spajic spajic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yorickov @spajic