Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mech_MX): fix crit error on logging undef addrs #31

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix(mech_MX): fix crit error on logging undef addrs #31

merged 2 commits into from
Oct 7, 2024

Conversation

DoobleD
Copy link
Contributor

@DoobleD DoobleD commented Oct 7, 2024

Fixes this error:

[CRIT] [-] [core] TypeError: Cannot read properties of undefined (reading 'join')
[CRIT] [-] [core]     at SPF.mech_mx (/<path>/Haraka/node_modules/haraka-plugin-spf/lib/spf.js:523:59)
[CRIT] [-] [core]     at async SPF.check_host (/<path>/Haraka/node_modules/haraka-plugin-spf/lib/spf.js:307:22)

Checklist:

  • docs updated
  • tests updated
  • Changes.md updated

@DoobleD DoobleD force-pushed the master branch 2 times, most recently from 7b3a40d to 723b0ec Compare October 7, 2024 13:50
@msimerson msimerson merged commit d22a909 into haraka:master Oct 7, 2024
8 checks passed
@msimerson msimerson mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimerson msimerson msimerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DoobleD @msimerson