New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid exception on undefined mx #17

Closed

DoobleD wants to merge 1 commit into haraka:master from DoobleD:master

Contributor

DoobleD commented Sep 7, 2023

Fixes the CRIT error below when the mx can't be resolved:

[CRIT] [-] [core] TypeError: Cannot read properties of undefined (reading 'join')
[CRIT] [-] [core]     at SPF.mech_mx (/mypath/Haraka/node_modules/haraka-plugin-spf/lib/spf.js:504:59)
[CRIT] [-] [core]     at async SPF.check_host (/mypath/Haraka/node_modules/haraka-plugin-spf/lib/spf.js:290:22)

Observed with node 16, haraka 3.0.2.

Checklist:

docs updated
tests updated
Changes.md updated


          fix: avoid exception on undefined mx

0c9fff1

Contributor Author

DoobleD commented Sep 7, 2023

I'm sorry I just realized this has been fixed already. Closing.

DoobleD closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet