Skip to content

Commit

Permalink
BUG/MINOR: quic: Unchecked pointer to packet number space.
Browse files Browse the repository at this point in the history
It is possible that there are still Initial crypto data in flight without
Handshake crypto data in flight. This is very rare but possible.

This issue was reported by long-rtt interop test with quic-go as client
and @chipitsine in GH #2276.

No need to backport.
  • Loading branch information
haproxyFred committed Sep 4, 2023
1 parent b50a471 commit 411ff15
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/quic_conn.c
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@ struct task *qc_process_timer(struct task *task, void *ctx, unsigned int state)
else {
TRACE_STATE("Cannot probe Initial packet number space", QUIC_EV_CONN_TXPKT, qc);
}
if (qc->hpktns->tx.in_flight) {
if (qc->hpktns && qc->hpktns->tx.in_flight) {
qc->flags |= QUIC_FL_CONN_RETRANS_NEEDED;
qc->hpktns->flags |= QUIC_FL_PKTNS_PROBE_NEEDED;
TRACE_STATE("needs to probe Handshake packet number space", QUIC_EV_CONN_TXPKT, qc);
Expand Down

0 comments on commit 411ff15

Please sign in to comment.