MINOR: quic: Help diagnosing malformed probing packets

Add a BUG_ON() to detect some malformed packets which are supposed to probe the peer without being ack-eliciting: the peer would not acknowledged such packets.
haproxytech · Nov 4, 2024 · 11891e1 · 11891e1
1 parent 2092199
commit 11891e1
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/quic_tx.c b/src/quic_tx.c
@@ -2071,6 +2071,8 @@ static int qc_do_build_pkt(unsigned char *pos, const unsigned char *end,
 		goto no_room;
 	}
 
+	BUG_ON(qel->pktns->tx.pto_probe &&
+	       !(pkt->flags & QUIC_FL_TX_PACKET_ACK_ELICITING));
 	/* If this packet is ack-eliciting and we are probing let's
 	 * decrement the PTO probe counter.
 	 */