BUG/MINOR: configuration: fix stats-show node to work without name

haproxytech · Nov 6, 2023 · bee8caf · bee8caf
1 parent c7d68f8
commit bee8caf
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/configuration/configuration.go b/configuration/configuration.go
@@ -1071,9 +1071,7 @@ func (s *SectionParser) statsOptions() interface{} { //nolint:gocognit
 				opt.StatsRefreshDelay = misc.ParseTimeout(v.Delay)
 			}
 		case *stats.ShowNode:
-			if v.Name != "" {
-				opt.StatsShowNodeName = misc.StringP(v.Name)
-			}
+			opt.StatsShowNodeName = misc.StringP(v.Name)
 		case *stats.URI:
 			if v.Prefix != "" {
 				opt.StatsURIPrefix = v.Prefix

diff --git a/models/stats_options.go b/models/stats_options.go
diff --git a/specification/build/haproxy_spec.yaml b/specification/build/haproxy_spec.yaml
@@ -7596,6 +7596,7 @@ definitions:
               pattern: ^[^\s]+$
               type: string
               x-nullable: true
+              x-omitempty: false
           stats_uri_prefix:
               pattern: ^[^\s]+$
               type: string

diff --git a/specification/models/configuration/misc.yaml b/specification/models/configuration/misc.yaml
@@ -245,6 +245,7 @@ stats_options:
       type: string
       pattern: '^[^\s]+$'
       x-nullable: true
+      x-omitempty: false
     stats_uri_prefix:
       type: string
       pattern: '^[^\s]+$'