Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript typings #39

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Add typescript typings #39

wants to merge 1 commit into from
+252 −2

Conversation

kanongil
Copy link
Contributor

I made my own typings, including the changes in the not yet merged #37.

@kanongil kanongil added the types TypeScript type definitions label Oct 23, 2024
@Marsup
Copy link
Contributor

Marsup commented Oct 23, 2024

Should we start with #34 (if I can make it work) and then move on with this one or is it not worth it?

@damusix
Copy link

damusix commented Oct 23, 2024

Should we start with #34 (if I can make it work) and then move on with this one or is it not worth it?

@Marsup Na, not worth it since this covers everything that would be up-to-date. There's really no benefit to #34 if this covers all typings, and does so more effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusix damusix damusix approved these changes

Assignees
No one assigned
Labels
types TypeScript type definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanongil @Marsup @damusix