chore: cleanup a few lint problems

Some small non-functional changes to avoid the IDE giving us false-positive problem warnings.
hankfreund · Oct 21, 2024 · d5efbda · d5efbda
1 parent e422d90
commit d5efbda
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/controller/direct/common/labels.go b/pkg/controller/direct/common/labels.go
@@ -23,7 +23,7 @@ func ComputeGCPLabels(labels map[string]string) map[string]string {
 }
 
 func RemoveByPrefixes(a map[string]string, prefixes ...string) {
-	for k, _ := range a {
+	for k := range a {
 		for i := range prefixes {
 			if strings.HasPrefix(k, prefixes[i]) {
 				delete(a, k)

diff --git a/pkg/controller/direct/monitoring/client.go b/pkg/controller/direct/monitoring/client.go
@@ -26,7 +26,7 @@ type gcpClient struct {
 	config config.ControllerConfig
 }
 
-func newGCPClient(ctx context.Context, config *config.ControllerConfig) (*gcpClient, error) {
+func newGCPClient(config *config.ControllerConfig) (*gcpClient, error) {
 	gcpClient := &gcpClient{
 		config: *config,
 	}

diff --git a/pkg/controller/direct/monitoring/monitoringdashboard_controller.go b/pkg/controller/direct/monitoring/monitoringdashboard_controller.go
@@ -64,7 +64,7 @@ var _ directbase.Adapter = &dashboardAdapter{}
 
 // AdapterForObject implements the Model interface.
 func (m *dashboardModel) AdapterForObject(ctx context.Context, kube client.Reader, u *unstructured.Unstructured) (directbase.Adapter, error) {
-	gcpClient, err := newGCPClient(ctx, m.config)
+	gcpClient, err := newGCPClient(m.config)
 	if err != nil {
 		return nil, fmt.Errorf("building gcp client: %w", err)
 	}
@@ -122,7 +122,7 @@ func (m *dashboardModel) AdapterForURL(ctx context.Context, url string) (directb
 
 	tokens := strings.Split(strings.TrimPrefix(url, "//monitoring.googleapis.com/"), "/")
 	if len(tokens) == 4 && tokens[0] == "projects" && tokens[2] == "dashboards" {
-		gcpClient, err := newGCPClient(ctx, m.config)
+		gcpClient, err := newGCPClient(m.config)
 		if err != nil {
 			return nil, fmt.Errorf("building gcp client: %w", err)
 		}