Ensure selection visible during "find"

[hanjinliu]

Summary by CodeRabbit

• New Features

  • Added scrolling functionality to 'Find Next' and 'Find Previous' in the table view.

• Improvements

  • Enhanced screen rectangle calculation for tables, improving display accuracy.

• Bug Fixes

  • Improved slice formatting to correctly handle NumPy number types.

[coderabbitai]

Walkthrough

The recent updates introduce improvements to scrolling functionality in the table view methods, optimize screen geometry calculations in table wrappers, and refine the slice representation in tabulous. Specifically, they ensure that the find methods in table views scroll to the searched index, employ more accurate screen geometry calculations, and enhance slice formatting to better handle NumPy number types.

Changes

Files	Change Summaries
tabulous/_qt/_table_stack/_finder.py	Updated findNext and findPrevious methods to include scrolling to the specific index in the table view.
tabulous/_qt/_table/_base/_table_wrappers.py	Changed screen geometry calculation to use QtGui.QGuiApplication.screenAt for more accurate screen positioning.
tabulous/_slice_op.py	Introduced a new function _repr for better handling of NumPy number types in slice formatting and updated the fmt function to use _repr.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Finder
    participant QTableView

    User ->> Finder: findNext()
    Finder ->> QTableView: get index (r, c)
    QTableView ->> Finder: returns index
    Finder ->> QTableView: scrollTo(index)
    
    User ->> Finder: findPrevious()
    Finder ->> QTableView: get index (r, c)
    QTableView ->> Finder: returns index
    Finder ->> QTableView: scrollTo(index)

Loading

Poem

Scroll to the row, to and fro,
The table's view now smoothly flows.
With coordinates so true,
Geometry anew,
Slices now with clarity glow! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1f72a00 and fec3728.

Files selected for processing (1)

• tabulous/_qt/_table_stack/_finder.py (2 hunks)

Additional comments not posted (2)

tabulous/_qt/_table_stack/_finder.py (2)

168-169: LGTM! Scrolling functionality added to findNext

The modification to scroll to the item in the table view after finding it enhances user experience by ensuring the found item is visible.

---

190-191: Great addition! Scrolling functionality in findPrevious

Adding the scrollTo method after finding the previous item is a useful enhancement for user interaction, ensuring visibility of the searched items.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fec3728 and 9c23ca6.

Files selected for processing (2)

• tabulous/_qt/_table/_base/_table_wrappers.py (1 hunks)
• tabulous/_slice_op.py (2 hunks)

Additional comments not posted (3)

tabulous/_slice_op.py (2)

56-59: Conversion to _repr in fmt function is well-targeted.

The modification to use _repr for string conversion specifically addresses the handling of NumPy number types, which is a sensible enhancement given the context of numerical data processing.

---

66-69: Addition of _repr function enhances type handling.

The introduction of _repr is a robust way to ensure that NumPy types are handled correctly, enhancing the flexibility and accuracy of type representation in string conversions.

tabulous/_qt/_table/_base/_table_wrappers.py (1)

87-89: Updated screen calculation in QPopupWidget is context-aware.

The change to calculate _screen_rect based on the parent's global position is a thoughtful improvement for multi-monitor setups. It ensures that the popup appears on the correct screen relative to the application.