Fixes for Qt6

[hanjinliu]

There were several bugs related to Qt6.

Summary by CodeRabbit

• Refactor
  • Improved color management by using centralized color role functions for UI elements across various modules.
• New Features
  • Enhanced responsiveness in tables by refining mouse interaction logic.

[coderabbitai]

Walkthrough

The recent updates to the Tabulous library focus on refining color and geometry handling across various components. Changes include using centralized color roles for improved consistency and modifying coordinate handling for gradients and paths to enhance UI rendering. These adjustments ensure a smoother and more reliable interface experience in Qt-based applications.

Changes

File Path	Change Summary
.../_qt/_preference/_shared.py	Updated to import and use foreground_color_role for color management in QTitleLabel.
.../_qt/_preference/_theme.py	Enhanced QLinearGradient and QPainterPath creation using QtCore.QPointF.
.../_qt/_qt_const.py	Introduced conditional color role functions for better compatibility with different Qt versions.
.../_qt/_table/_animation.py	Modified to use background_color_role for background color retrieval in animations.
.../_qt/_table/_base/...	Added early exit in mouseMoveEvent if no mouse buttons are pressed, optimizing event handling.

Poem

🐰🎨
A hop through code, colors align,
With gradients smooth and fine.
The rabbit tweaks with care and flare,
Paths and palettes beyond compare.
Changes made, the UI gleams—
A coderabbit's pixel dreams.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7d500ed and cfed3af.

Files selected for processing (5)

• tabulous/_qt/_preference/_shared.py (2 hunks)
• tabulous/_qt/_preference/_theme.py (1 hunks)
• tabulous/_qt/_qt_const.py (2 hunks)
• tabulous/_qt/_table/_animation.py (2 hunks)
• tabulous/_qt/_table/_base/_enhanced_table.py (1 hunks)

Additional comments not posted (6)

tabulous/_qt/_preference/_shared.py (2)

4-4: Import statement added for foreground_color_role. This centralizes color management, enhancing maintainability.

---

17-17: Usage of foreground_color_role for color management in paintEvent. This change improves code consistency and maintainability.

tabulous/_qt/_qt_const.py (1)

15-33: Conditional functions foreground_color_role and background_color_role added. These functions correctly abstract color fetching based on the QT6 flag, improving code maintainability and adaptability.

tabulous/_qt/_preference/_theme.py (1)

74-91: Refinement in paintEvent using QtCore.QPointF for more precise point definition in gradients and paths. This enhances the visual rendering and flexibility.

tabulous/_qt/_table/_animation.py (1)

127-127: Use of background_color_role in get_brush method for fetching background color. This centralizes color management and enhances maintainability.

tabulous/_qt/_table/_base/_enhanced_table.py (1)

363-364: Added condition in mouseMoveEvent to check for no buttons pressed, preventing unnecessary processing and enhancing responsiveness.