-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update migrations #900
Merged
Merged
Update migrations #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
added
blockchain
part of the codebase
migrations
part of the codebase
wallet-db
part of the codebase
labels
Jul 3, 2024
Tested migration from v2.1.3 to this branch for |
nodech
force-pushed
the
update-migrations
branch
2 times, most recently
from
August 26, 2024 14:49
89ce0ec
to
15bedd8
Compare
nodech
force-pushed
the
update-migrations
branch
from
August 26, 2024 14:58
15bedd8
to
1cebcd3
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Migrations
Old migrations depend on the methods and states that may be broken by the future updates to the codebase. This PR attempts to fix old migrations to reduce depenencies to the codebase. For example, Change address migration is currently broken, if user were to migrate from earlier non-fixed versions (e.g. v2.1.0)
Migrations are now run against generated data from the original versions of hsd. Generator and generated codes can be found in
test/data/migrations
, for both the wallet and the chain.This PR attempts to go over all migrations. Review and fix test cases and migrations:
still depends on wallet/walletkey, wallet/path and
wallet/records.MapRecord.