opencl: adjust threads and blocks options. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default threads (total work items) and blocks (work group size) cli options have the potential to cause errors for opencl capable devices. This commit makes sure the options are lowered to the device's default values, if necessary. If the resultant total work items value is not divisible by the work group size, the total work items value is lowered to the closest multiple of the work group size. We also print the values to alert users of any changes to cli options.
|
Fixes #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default threads (total work items) and blocks (work group size) cli
options have the potential to cause errors for opencl capable devices.
This commit makes sure the options are lowered to the device's default
values, if necessary. If the resultant total work items value is not
divisible by the work group size, the total work items value is lowered
to the closest multiple of the work group size. We also print the values
to alert users of any changes to cli options.
This PR is a:
Checklist:
If this PR is an optimization, please report benchmarks along with your device
name: