Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call the onChange callback on the first render #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davecalnan
Copy link
Collaborator

@davecalnan davecalnan commented Sep 7, 2022

This PR:

  • Fixes the error from React about updating the component while rendering by skipping calling the onChange callback during the first render

Before

Screenshot 2022-09-07 at 19 59 11

After

Screenshot 2022-09-07 at 19 59 29

@skylerkatz
Copy link

@aarondfrancis any chance this PR can get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants