Improve redirections #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It changes the semantics of `EDSL.with_redirections` to be the one of the shell's `exec` built-in.
ihodes
reviewed
Feb 3, 2017
src/lib/EDSL.mli
Outdated
| - then, ["printf"] outputs to [1]. | ||
|
|
||
| Invalid cases, like redirecting to a file-descriptor has not been | ||
| openned, lead to undefined behavior; see |
src/test/main.ml
Outdated
| write_output | ||
| ~return_value:tmp2#path ( | ||
| with_redirections (exec ["printf"; "%s"; recognizable]) [ | ||
| to_fd (int 4) (int 3); |
There was a problem hiding this comment.
This redirection is the one that fails, since fd 3 is not yet opened.
In the POSIX case, with_redirections then exits, in the bash/zsh case it keeps going.
There was a problem hiding this comment.
gotcha, now i understand what's going on 🙏
| assert_or_fail "fd3" ( | ||
| (tmp1#get =$= string "") | ||
| ||| | ||
| (this_is_bash |
There was a problem hiding this comment.
why would we expect the file to have the string in it in bash? (and why only bash?)
There was a problem hiding this comment.
Bash does not exit on failed exec calls.
Cf. #41
(and the doc-comments of EDSL.with_redirections)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #41 for some explanations of “how” and #40 for the “why.”