Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper tab in the laptop list in the Makefile #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

l29ah
Copy link

@l29ah l29ah commented Dec 1, 2017

No description provided.

@hamishcoleman
Copy link
Owner

What is the advantage of making this change?

On the flip side, writing it as "\t" means that even in editors where the difference between soft and hard tabs are unclear (which is most of them), it is still clear that you have written the right one.

(I also have to stop and comment on the irony of talking about tabs in a Makefile, which has its own love/hate relationship with tabs)

@l29ah
Copy link
Author

l29ah commented Jan 28, 2018

It is displayed as \t otherwise, afair.

@hamishcoleman
Copy link
Owner

Ah, that is a little more annoying - it doesnt happen for me, so clearly different shell or make versions are at play here.

Can you try changing it to 'echo -e "$$i.img\t....."' ?

@l29ah
Copy link
Author

l29ah commented Jan 28, 2018

GNU bash, version 4.4.12(1)-release (x86_64-pc-linux-gnu)

Yes, it works fine w/ -e.

hamishcoleman added a commit that referenced this pull request Feb 1, 2018
This allows us to use options to echo that in turn allow it to interpret
the tab escape sequence.  Some systems would be using other shells by default,
so this should make the environment more consistant.
@hamishcoleman
Copy link
Owner

I've pushed a change in 95b63fa that should address this setting.

@l29ah l29ah closed this Feb 1, 2018
@hamishcoleman
Copy link
Owner

This problem with displaying things will probably have resurfaced as part of other work. Since it is a cosmetic display-only issue, I can live with that for the moment.

But - reopening to remind me to fix it better

@hamishcoleman hamishcoleman reopened this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants