-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extractor for *.FL[12] files #162
base: master
Are you sure you want to change the base?
Conversation
# | ||
|
||
# EL TORITO offset count (thanks to Hamish Coleman) | ||
FAT_OFFSET=71680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure you are aware - this number has been known to change, and is an artifact of the Lenovo build process (and not guaranteed). There is a way to calculate it, if needed
scripts/extract_from_ISO.sh
Outdated
exit 16 | ||
fi | ||
|
||
read -r FL1VERNUM FL1VER FL2VERNUM FL2VER < <(grep -E "^${ISO%%.iso*}" ../Descriptions.txt| \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean "$DESC" here, instead of ../Descriptions.txt ?
Also, you are treating a free-form text string as a set of fixed format fields when you extract the various version numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean "$DESC" here, instead of ../Descriptions.txt ?
Yeah. That's a typo. I'll fix it.
Also, you are treating a free-form text string as a set of fixed format fields when you extract the various version numbers.
I looked at the format of the file, and I see that there is a bit of commonality between all the version lines, so I'm counting on this structure. The issue is that for the EC versioning. there is no way that I know off to figure out the EC version number from the contents of a given ISO. However, I'm hoping there is something, which I have not yet figured out myself, which allows that. It is possible for the BIOS version string (not the number itself), which I can implement.
Any suggestions?
This pull request adds a generic extractor script for FL1 and FL2 files. The script requires 2 options, the ISO name to process, and the path to Descriptions.txt (to get EC version Number, which cannot be found in the ISO by path manipulation.)