Add changelog fragment and lint (ansible-collections#62)

ham-laru · Mar 22, 2023 · 25b905c · 25b905c
1 parent 5f0caeb
commit 25b905c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelogs/fragments/161-workaround-prompt-with-space.yml b/changelogs/fragments/161-workaround-prompt-with-space.yml
@@ -0,0 +1,3 @@
+minor_changes:
+  - command - workaround for extra characters in stdout (#62) in RouterOS versions between 6.49 and 7.1.5
+    (https://github.com/ansible-collections/community.routeros/pull/161).
diff --git a/plugins/module_utils/routeros.py b/plugins/module_utils/routeros.py
@@ -107,11 +107,10 @@ def should_add_leading_space(module):
     """Determines whether adding a leading space to the command is needed
     to workaround prompt bug in 6.49 <= ROS < 7.2"""
     capabilities = get_capabilities(module)
-    network_os_version = capabilities.get('device_info',{}).get('network_os_version')
+    network_os_version = capabilities.get('device_info', {}).get('network_os_version')
     if network_os_version is None:
         return False
-    version = LooseVersion(network_os_version)
-    return (version >= LooseVersion('6.49')) and (version < LooseVersion('7.2'))
+    return LooseVersion('6.49') <= LooseVersion(network_os_version) < LooseVersion('7.2')
 
 def run_commands(module, commands, check_rc=True):
     responses = list()