WIP: Refactor OAuth2 login for Halo 2.20 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <[email protected]>
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JohnNiang
commented
Sep 26, 2024
| @@ -8,14 +8,15 @@ group 'run.halo.oauth' | |||
| sourceCompatibility = JavaVersion.VERSION_17 | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
Remove the line after merging halo-dev/halo#6702.
build.gradle
Outdated
| maven { url 'https://s01.oss.sonatype.org/content/repositories/releases' } | ||
| maven { url 'https://s01.oss.sonatype.org/content/repositories/snapshots/' } | ||
| maven { url 'https://repo.spring.io/milestone' } | ||
| mavenCentral() | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation platform('run.halo.tools.platform:plugin:2.17.0-SNAPSHOT') | ||
| implementation platform('run.halo.tools.platform:plugin:2.20.0+local.5') |
There was a problem hiding this comment.
Change the version to 2.20.0-SNAPSHOT after merging halo-dev/halo#6702.
Signed-off-by: JohnNiang <[email protected]>
Signed-off-by: JohnNiang <[email protected]>
f2c-ci-robot bot
pushed a commit
to halo-dev/halo
that referenced
this pull request
Sep 29, 2024
#### What type of PR is this? /kind improvement /area core /milestone 2.20.x #### What this PR does / why we need it: This PR add support for binding OAuth2 user automatically. So we can remove the user-binding page. Please note that those changes may break the OAuth2 and SocialLogin plugins. #### Special notes for your reviewer: Build OAuth2 plugin from <halo-sigs/plugin-oauth2#64> or use [plugin-oauth2-1.0.4-SNAPSHOT.zip](https://github.com/user-attachments/files/17177592/plugin-oauth2-1.0.4-SNAPSHOT.zip) I built. - Bind after logging in 1. Log in Halo with username and password method 2. Try to unbind OAuth2 user 3. Bind OAuth2 user again - Initially bind without logging in 1. Go to login page 2. Log in with OAuth2 method and you will be redirected to login page 3. Log in with username and password method 4. See the result of binding - Log in with OAuth2 method after binding 1. Go to login page 2. Log in with OAuth2 method and you will be redirected to uc page directly #### Does this PR introduce a user-facing change? ```release-note 支持自动绑定 OAuth2 登录用户 ```
Signed-off-by: JohnNiang <[email protected]>
JohnNiang
commented
Sep 30, 2024
| public final class Oauth2LoginConfiguration { | ||
| @Configuration | ||
| @EnableAsync | ||
| public class Oauth2LoginConfiguration { |
There was a problem hiding this comment.
Why do I remove the final keyword?
Because the annotation @Configuration requires the class is non-final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors OAuth2 login for adapting Halo 2.20. See halo-dev/halo#6702 for more.
How to build?
./gradlew publishToMavenLocal -Pversion=2.20.0+local.5in Halo project./gradlew buildin current project.