-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move @halo-sigs/richtext-editor to this repository #4934
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4934 +/- ##
=========================================
Coverage 56.76% 56.76%
Complexity 2990 2990
=========================================
Files 517 517
Lines 17131 17131
Branches 1283 1283
=========================================
Hits 9725 9725
Misses 6862 6862
Partials 544 544 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
不要忘记将仓库 https://github.com/halo-sigs/richtext-editor 归档,并链接到新的地址。
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) * chore: move @halo-sigs/richtext-editor to this repository Signed-off-by: Ryan Wang <[email protected]>
What type of PR is this?
/area console
/area editor
/kind improvement
/milestone 2.11.x
What this PR does / why we need it:
将 https://github.com/halo-sigs/richtext-editor 移动到此仓库进行管理。
Which issue(s) this PR fixes:
Fixes #4932
Special notes for your reviewer:
测试方式:
console/packages/editor
目录,执行pnpm dev
,测试能否正常使用开发环境。pnpm build:packages
,然后启动 Console 的 dev server,测试在 Console 中能否正常使用编辑器。Does this PR introduce a user-facing change?