Added -d postfix to libs. Adjust int casting. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halex2005
reviewed
Jan 1, 2017
| @@ -49,7 +49,7 @@ namespace nowide { | |||
| return 0; | |||
| if(n >= buf_size) { | |||
| tmp.resize(n+1,L'\0'); | |||
| n = GetEnvironmentVariableW(name.c_str(),&tmp[0],tmp.size() - 1); | |||
| n = GetEnvironmentVariableW(name.c_str(),&tmp[0], static_cast<unsigned long>(tmp.size() - 1)); | |||
There was a problem hiding this comment.
according to https://msdn.microsoft.com/en-us/library/windows/desktop/ms683188(v=vs.85).aspx, cast should be written as static_cast<DWORD>
| @@ -43,8 +45,8 @@ namespace details { | |||
| { | |||
| if(!handle_) | |||
| return -1; | |||
| int n = pptr() - pbase(); | |||
| int r = 0; | |||
| DWORD n = static_cast<DWORD>(pptr() - pbase()); | |||
There was a problem hiding this comment.
instead DWORD, pointers math should be calculated with ptrdiff_t type.
| @@ -59,29 +61,29 @@ namespace details { | |||
| } | |||
| private: | |||
|
|
|||
| int write(char const *p,int n) | |||
| DWORD write(char const *p, DWORD n) | |||
There was a problem hiding this comment.
I think that size_t is better for 64-bit portability
| @@ -193,13 +195,13 @@ namespace details { | |||
| return out - buffer_; | |||
| } | |||
|
|
|||
| static const size_t buffer_size = 1024 * 3; | |||
| static const size_t wbuffer_size = 1024; | |||
| static const DWORD buffer_size = 1024 * 3; | |||
There was a problem hiding this comment.
size_t was better for 64-bit portability
|
Your PR contains two unrelated changes:
Please, split them to different PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider for merging.