Handle session expiration time issue #89. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intends to resolve issue #89.
The main idea is to take advantage of the
expires_inresponse from the server.Whenever we know the token is already expired, we don't need to send out a request that is certain to fail at least with 401 (if no other network issue is there like DNS, server availability etc).
Without this:
-> tokens are expired
-> request goes out
-> gets 401
-> authenticator refreshes the tokens
-> request is resent with updated tokens
-> data received
With the current changes:
-> tokens are expired
-> expiration timestamp is checked, signaling expiration
-> authenticator refreshes the tokens
-> request is sent with updated tokens
-> data received
For backwards compatibility this is not enabled by default. To take advantage of this a separate
TokenExpirationStoragehas to be implemented. A combined SharedPref storage for bothTokenExpirationStorageandAuthenticationLocalStorageis implemented.