Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle session expiration time #89

Open
fknives opened this issue Jul 19, 2022 · 0 comments · May be fixed by #94
Open

Handle session expiration time #89

fknives opened this issue Jul 19, 2022 · 0 comments · May be fixed by #94
Labels
enhancement New feature or request

Comments

@fknives
Copy link
Contributor

fknives commented Jul 19, 2022

Request
Refresh the accessToken before refreshToken is expired. This would result in less unnecessary requests we know would fail with 401.

Reasoning
With the current implementation we are expecting 401, which is fine if the accessToken is valid for days. However a short span access token, like an hour, would mean a lot more unnecessary requests.
This can be circumvented by observing the accessTokenExpiration before the request is even fired.

@fknives fknives added the enhancement New feature or request label Jul 19, 2022
@fknives fknives linked a pull request Sep 7, 2022 that will close this issue
@fknives fknives linked a pull request Sep 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant