test: add getUserConfigFile coverage #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kien-ht
reviewed
Dec 27, 2023
| const config = getUserConfigFile(); | ||
| expect(config).toEqual(mockedDefaultConfig); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I think it would be great if we could have a test case where users have partial config file. We should be able to pick up the custom config as well as the default ones. The rest looks great to me.
There was a problem hiding this comment.
Great idea! Will add soon
There was a problem hiding this comment.
@kien-ht I haven't found a way to test userConfig as it was a constant before even importing it to the test. It might be just my lack of knowledge, but didn't manage to test it this way.
- I changed
userConfigto agetUserConfigfunction, although I am not sure if that is even a good idea. Updated in the affected places as well.
Let me know if I should undo the changes (feel free to push back) and skip userConfig/getUserConfig tests. Not sure if using it as a function would affect any behaviour 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getUserConfigFilefunctionuserConfigconst to a function =>getUserConfigsince I was not able to test it as it was.getUserConfigfunction