Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] remove unused inputs to batch_worker_image #14712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ci] remove unused inputs to batch_worker_image #14712

wants to merge 1 commit into from
+0 −2

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Oct 3, 2024 •
edited
Loading

Change Description

The letsencrypt inputs to batch_worker_image are duplicated (though
the second time were localised to an unreachable location).

Security Assessment

  • This change has no security impact

Description of the security impact and necessary mitigations:

These files were unreachable from the ci job.

(Reviewers: please confirm the security impact before approving)

chrisvittal
chrisvittal approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love changes that are all deletions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvittal chrisvittal chrisvittal approved these changes

@cjllanwarne cjllanwarne Awaiting requested review from cjllanwarne

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehigham @chrisvittal