[vds] More updates for preferring LEN over END #14681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvittal
changed the title
chrisvittal
force-pushed
the
vds/densify-use-len
branch
3 times, most recently
from
9aaf0a6
to
7891ee2
Compare
chrisvittal
force-pushed
the
vds/densify-use-len
branch
from
7891ee2
to
baec661
Compare
We still need to calculate a global position for the end of a reference block, but this version is cleaner.
chrisvittal
force-pushed
the
vds/densify-use-len
branch
from
baec661
to
c898b39
Compare
ehigham
requested changes
Oct 8, 2024
|
|
||
| # NOTE: There is a strong assumption that ref block LEN does not extend | ||
| # past the end of a contig. That is bad data and we won't correct for it. | ||
| # Garbage in, garbage out. |
chrisvittal
force-pushed
the
vds/densify-use-len
branch
from
ed26880
to
02e9ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_dense_mt. We still need to calculate a global position for the end of a reference block, but this version is cleaner.truncate_reference_blocks.