Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add session to the arguments of switch_page fn #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

russHyde
Copy link
Contributor

The text describes how the 'switch_page' function can be brought outside of the 'server' function if a 'session' argument is added to it.
But, the definition of 'switch_page' in the subsequent code block did not have a 'session' argument.
Hence, 'session' arg was added in (and passed to updateTabsetPanel).

Hope this makes sense, and I haven't misunderstood the original code.


Also wondering whether updateTabsetPanel should be passed an explicit 'inputId = ...' rather than implicit 'input = ...'

The text describes how the 'switch_page' function can be brought outside of the 'server' function if a 'session' argument is added to it.
But, the definition of 'switch_page' in the subsequent code block did not have a 'session' argument.
Hence, 'session' arg was added in (and passed to updateTabsetPanel).

Hope this makes sense, and I haven't misunderstood the original code.
@hadley
Copy link
Owner

hadley commented Mar 26, 2021

Gah, this whole section needs to be re-written because updateTabsetPanel no longer needs the session argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants