-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port from bookdown to quarto #365
Conversation
@hadley okay we have a minimum viable PR (is MVPR an accepted term?) to switch to quarto. As always there are some rough edges. The most noticeable is that the switch from the bespoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Agree that we should get the big changes merged and then start polishing 😄
|
||
- uses: r-lib/actions/setup-r@v2 | ||
with: | ||
use-public-rspm: true | ||
|
||
- uses: r-lib/actions/setup-r-dependencies@v2 | ||
|
||
- name: Cache bookdown results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you deliberately drop the caching? I have no idea if it's important or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semi-deliberate. I'm not entirely sure what (if any) files need to be cached in the quarto book, and since there's no caching used in the r4ds book workflow (which I was using as a guide) I didn't try to add anything. Maybe we leave it as is and try restoring the cache later if we have build issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having now merged I can see why we had a cache. The actions workflow takes about 20 mins to finish and I had timeout issues the first time. I'll open an issue to restore the cache and see what needs to happen. Edit: Issue is #366
Substantive changes
columns()
function (currently only fixes the number of columns, not the size or aspect ratio of plots)Other changes
status()
function to show callouts for each chapterset.seed()
called consistently in common.R instead of inconsistently in some chaptersSomething confusing
Proposed next steps