Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-generic RegisterInstance overload #695

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add non-generic RegisterInstance overload #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76dd321
Allow registering instance as a type without generics
Valax321 Jul 25, 2024
78a3c73
Merge branch 'hadashiA:master' into master
Valax321 Sep 18, 2024
2e41fb4
Merge branch 'hadashiA:master' into master
Valax321 Oct 27, 2024
a7f36a9
Merge branch 'hadashiA:master' into master
Valax321 Nov 5, 2024
0663810
Filter out abstract types from parent dropdown
Valax321 Nov 5, 2024
c842dea
Merge branch 'hadashiA:master' into master
Valax321 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions VContainer/Assets/VContainer/Editor/ParentReferencePropertyDrawer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ static string[] GetAllTypeNames()
{
return new List<string> { "None" }
.Concat(TypeCache.GetTypesDerivedFrom<LifetimeScope>()
.Where(x => !x.IsAbstract)
.Select(type => type.FullName))
.ToArray();
}
Expand Down
9 changes: 8 additions & 1 deletion VContainer/Assets/VContainer/Runtime/ContainerBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,14 @@ public static RegistrationBuilder Register<TInterface>(
Func<IObjectResolver, TInterface> implementationConfiguration,
Lifetime lifetime)
=> builder.Register(new FuncRegistrationBuilder(container => implementationConfiguration(container), typeof(TInterface), lifetime));


[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static RegistrationBuilder RegisterInstance(
this IContainerBuilder builder,
object instance,
Type implementationType)
=> builder.Register(new InstanceRegistrationBuilder(instance)).As(implementationType);

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static RegistrationBuilder RegisterInstance<TInterface>(
this IContainerBuilder builder,
Expand Down