Merge pull request #123 from hadashiA/ku/typed-parameter-arg

Fix .WithParameter argument strictly
hadashiA · Feb 13, 2021 · d231380 · d231380 · vercel · Feb 13, 2021
2 parents 3d545a8 + 22e9c0f
commit d231380
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/VContainer/Assets/VContainer/Runtime/RegistrationBuilder.cs b/VContainer/Assets/VContainer/Runtime/RegistrationBuilder.cs
@@ -108,7 +108,7 @@ public RegistrationBuilder WithParameter(Type type, object value)
             return this;
         }
 
-        public RegistrationBuilder WithParameter<TParam>(object value)
+        public RegistrationBuilder WithParameter<TParam>(TParam value)
         {
             return WithParameter(typeof(TParam), value);
         }

diff --git a/VContainer/Assets/VContainer/Runtime/Unity/ContainerBuilderUnityExtensions.cs b/VContainer/Assets/VContainer/Runtime/Unity/ContainerBuilderUnityExtensions.cs
@@ -64,23 +64,20 @@ public static void UseEntryPoints(
             Lifetime lifetime,
             Action<EntryPointsBuilder> configuration)
         {
-            var entryPoints = new EntryPointsBuilder(builder, lifetime);
-            configuration(entryPoints);
+            configuration(new EntryPointsBuilder(builder, lifetime));
         }
 
         public static void UseComponents(this IContainerBuilder builder, Action<ComponentsBuilder> configuration)
         {
-            var components = new ComponentsBuilder(builder);
-            configuration(components);
+            configuration(new ComponentsBuilder(builder));
         }
 
         public static void UseComponents(
             this IContainerBuilder builder,
             Transform root,
             Action<ComponentsBuilder> configuration)
         {
-            var components = new ComponentsBuilder(builder, root);
-            configuration(components);
+            configuration(new ComponentsBuilder(builder, root));
         }
 
         public static RegistrationBuilder RegisterEntryPoint<T>(this IContainerBuilder builder, Lifetime lifetime)