Merge pull request #91 from hadashiA/ku/fix-duplicate-singleton

Fix a bug where Singletons are duplicated if the child has the same interface
hadashiA · Jan 15, 2021 · bab0877 · bab0877 · vercel · Jan 15, 2021
2 parents 9e75a81 + 18077da
commit bab0877
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 22 deletions.
diff --git a/VContainer/Assets/VContainer/Runtime/Container.cs b/VContainer/Assets/VContainer/Runtime/Container.cs
@@ -69,7 +69,7 @@ public object Resolve(IRegistration registration)
                     if (Parent is null)
                         return Root.Resolve(registration);
 
-                    if (!registry.Exists(registration))
+                    if (!registry.Exists(registration.ImplementationType))
                         return Parent.Resolve(registration);
 
                     return CreateTrackedInstance(registration);

diff --git a/VContainer/Assets/VContainer/Runtime/Internal/FixedTypeKeyHashTableRegistry.cs b/VContainer/Assets/VContainer/Runtime/Internal/FixedTypeKeyHashTableRegistry.cs
@@ -107,20 +107,6 @@ public bool TryGet(Type interfaceType, out IRegistration registration)
             return false;
         }
 
-        public bool Exists(IRegistration registration)
-        {
-            if (registration.InterfaceTypes?.Count > 0)
-            {
-                foreach (var type in registration.InterfaceTypes)
-                {
-                    if (hashTable.TryGet(type, out _))
-                    {
-                        return true;
-                    }
-                }
-                return false;
-            }
-            return hashTable.TryGet(registration.ImplementationType, out _);
-        }
+        public bool Exists(Type type) => hashTable.TryGet(type, out _);
     }
-}
+}
diff --git a/VContainer/Assets/VContainer/Runtime/Internal/IRegistry.cs b/VContainer/Assets/VContainer/Runtime/Internal/IRegistry.cs
@@ -6,6 +6,6 @@ interface IRegistry
     {
         // void Add(Registration registration);
         bool TryGet(Type interfaceType, out IRegistration registration);
-        bool Exists(IRegistration registration);
+        bool Exists(Type implementationType);
     }
 }
diff --git a/VContainer/Assets/VContainer/Tests/ScopedContainerTest.cs b/VContainer/Assets/VContainer/Tests/ScopedContainerTest.cs
@@ -80,13 +80,23 @@ public void CreateScopeAndRegister()
         public void CreateScopeWithResolveSingleton()
         {
             var builder = new ContainerBuilder();
-            builder.Register<NoDependencyServiceA>(Lifetime.Singleton);
+            builder.Register<DisposableServiceA>(Lifetime.Singleton)
+                .AsImplementedInterfaces()
+                .AsSelf();
 
             var container = builder.Build();
-            var scopedContainer = container.CreateScope();
+            var scopedContainer = container.CreateScope(childBuilder =>
+            {
+                childBuilder.Register<DisposableServiceB>(Lifetime.Singleton)
+                    .AsImplementedInterfaces()
+                    .AsSelf();
+            });
 
-            var singleton = scopedContainer.Resolve<NoDependencyServiceA>();
-            Assert.That(singleton, Is.InstanceOf<NoDependencyServiceA>());
+            var singleton = container.Resolve<DisposableServiceA>();
+            var singleton2 = scopedContainer.Resolve<DisposableServiceA>();
+            Assert.That(singleton, Is.InstanceOf<DisposableServiceA>());
+            Assert.That(singleton2, Is.InstanceOf<DisposableServiceA>());
+            Assert.That(singleton, Is.EqualTo(singleton2));
         }
 
         [Test]