Fix CappedArrayPool : 1. alloc new array without caching 2. some cach…

…ed array is not be used
hadashiA · May 13, 2024 · 2695c6c · 2695c6c
1 parent 5861081
commit 2695c6c
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/VContainer/Assets/VContainer/Runtime/Internal/CappedArrayPool.cs b/VContainer/Assets/VContainer/Runtime/Internal/CappedArrayPool.cs
@@ -24,7 +24,7 @@ internal CappedArrayPool(int maxLength)
                 {
                     buckets[i][j] = new T[arrayLength];
                 }
-                tails[i] = buckets[i].Length - 1;
+                tails[i] = 0;
             }
         }
 
@@ -48,7 +48,12 @@ public T[] Rent(int length)
                     buckets[i] = bucket;
                 }
 
-                var result = bucket[tail] ?? new T[length];
+                if (bucket[tail] == null)
+                {
+                    bucket[tail] = new T[length];
+                }
+
+                var result = bucket[tail];
                 tails[i] += 1;
                 return result;
             }