fix(engine/fstar): fix c_trait_goal and always use it for traits
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
added 6 commits
June 26, 2024 18:08
This reverts commit 253fb96.
W95Psp
force-pushed
the
fix-719-for-good---hopefully
branch
from
d62f979 to
35145cc
Compare
|
We're still debugging this |
|
Closing in favor of #751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #719, this time for good, I hope.
This PR is marked draft because I'm checking right now whether this solves the bug.I checked running
hax.pyon MLKem, the first error I see seems unrelated to #719.Update: I need to change the fstar libraryStatus: should be OKit is not 😭