-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate visitors automatically #698
Conversation
11b75c8
to
6cab1d2
Compare
bb9ce9b
to
99d4614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this PR.
You generate the visitor code but then also commit it? What is the intended workflow here?
No, I commit small visitors for the types used by the visitor generator 😅 so yes, that's particularly confusing. That utility defines a small AST for representing types, and I needed visitors for that small AST, which I generated using the tool itself, but since it's that AST is a bit different, I had to do manual edits. That's why I commit that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comments to all the new code before merging.
…n_conv.Primitives`
7505312
to
0efd46c
Compare
This PR:
generate_visitors
that derive those visitors reading the ast.ml module;ast_visitors
usinggenerate_visitors
Note: the CI is failing for Charon, but that's likely because of rustc updates