Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle naming fixes #1205

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Bundle naming fixes #1205

merged 4 commits into from
Dec 24, 2024

Conversation

maximebuyse
Copy link
Contributor

@maximebuyse maximebuyse commented Dec 19, 2024

This PR:

@maximebuyse
Copy link
Contributor Author

@karthikbhargavan You can try this and see if it works for you.

@maximebuyse maximebuyse marked this pull request as ready for review December 24, 2024 09:57
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but two comments, since we are touching this code anyway.

First, can we rename "Rec_bundle" to "Cyclic_bundle"? This would be more precise.
Second, could we list the files that are part of the bundle in the top of the file somehow?

I can imagine the second ask to be harder.

engine/lib/concrete_ident/concrete_ident.ml Outdated Show resolved Hide resolved
@maximebuyse
Copy link
Contributor Author

@maximebuyse
Copy link
Contributor Author

Generally looks good, but two comments, since we are touching this code anyway.

First, can we rename "Rec_bundle" to "Cyclic_bundle"? This would be more precise. Second, could we list the files that are part of the bundle in the top of the file somehow?

I can imagine the second ask to be harder.

Done for the first one. The list of files (or maybe modules) is a good idea, but let's leave it for later. I think trying to name the bundle with a name containing the names of the modules it contains (which is part of the naming refactor) would already help.

@karthikbhargavan karthikbhargavan self-requested a review December 24, 2024 11:32
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge if libcrux CI passes.

@maximebuyse maximebuyse added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 08057f7 Dec 24, 2024
15 checks passed
@maximebuyse maximebuyse deleted the bundle-naming-fixes branch December 24, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable name for rec bundles clash of impl names in rec bundles (disambiguators are no longer valid)
2 participants