-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle naming fixes #1205
Bundle naming fixes #1205
Conversation
@karthikbhargavan You can try this and see if it works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but two comments, since we are touching this code anyway.
First, can we rename "Rec_bundle" to "Cyclic_bundle"? This would be more precise.
Second, could we list the files that are part of the bundle in the top of the file somehow?
I can imagine the second ask to be harder.
Done for the first one. The list of files (or maybe modules) is a good idea, but let's leave it for later. I think trying to name the bundle with a name containing the names of the modules it contains (which is part of the naming refactor) would already help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's merge if libcrux CI passes.
This PR: