Improve `setup.sh` #1146

W95Psp · 2024-11-27T15:29:55Z

This PR:

fixes Build error: binaries seems cached to eagerly #1145 by cleaning both cargo and dune before doing anything
adds a --no-cleanup flag to disable this cleaning behavior if wanted
adds a --help flag and a help message

… flag

karthikbhargavan · 2024-11-27T15:35:05Z

hm, this is going to be hard to test since I have now cleaned up my state. shall we find someone with a dirty state?

karthikbhargavan

Looks right, did not check if it fixes the issue because I cannot repro the issue on my current state.

W95Psp · 2024-11-27T15:41:03Z

Yes, I think that's a bit complicated to test 😅
Let's merge then, thanks for the fast review :)

W95Psp added 3 commits November 27, 2024 16:17

misc(setup.sh): rebuild.sh -> just build

3159397

feat(setup.sh): cleanup cargo & dune by default, add a --no-cleanup…

1dc71b0

… flag

feat(setup.sh): add --help message

c297dc5

W95Psp requested review from karthikbhargavan and franziskuskiefer November 27, 2024 15:29

karthikbhargavan approved these changes Nov 27, 2024

View reviewed changes

W95Psp enabled auto-merge November 27, 2024 15:41

W95Psp added this pull request to the merge queue Nov 27, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024

W95Psp added 2 commits November 27, 2024 16:54

fix(setup.sh): clean: use opam, not dune

62366a4

fix(setup.sh): first check for binaries, then do cleanup

37fee7a

W95Psp mentioned this pull request Nov 27, 2024

Engine: F*: fix \0 #1147

Merged

W95Psp enabled auto-merge November 27, 2024 15:56

W95Psp added this pull request to the merge queue Nov 27, 2024

Merged via the queue into main with commit c7f0431 Nov 27, 2024
15 checks passed

W95Psp deleted the setup-sh-clean branch November 27, 2024 16:30

Provide feedback