Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webusb-site deployment by not using DEPLOY_PAT #74

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

francisduvivier
Copy link
Collaborator

@francisduvivier francisduvivier commented Oct 8, 2024

Currently a personal access token is used, but I could not get the action for the web-usb deployment to the gh-pages branch working with that.

Instead I just updated the action and removed the token, so this requires that in the repo settings, github actions should have write access to this repo. But I think that already is the case in this repo actually.

  • Also added a .tool-versions file for specifying the node version when used with asdf
    Tested and working in my fork, I deployed with that to https://cz20-badge.francisd.be/

Francis Duvivier added 3 commits October 8, 2024 20:18
Since I don't find an option to make a token with code push permissions and actually I don't see a reason why not to just give the github actions push access in general via the settings and make use of that.
@francisduvivier francisduvivier changed the title Fix deployment by not using PA_TOKEN Fix webusb-site deployment by not using PA_TOKEN Oct 8, 2024
@francisduvivier francisduvivier changed the title Fix webusb-site deployment by not using PA_TOKEN Fix webusb-site deployment by not using DEPLOY_PAT Oct 8, 2024
@tjclement tjclement merged commit 75b260f into hackzone:master Oct 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants