Use script and env

hackolade · Sep 21, 2023 · bc50916 · bc50916
1 parent a80ebf7
commit bc50916
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/discover-and-prepare-upstream-native-modules.yml b/.github/workflows/discover-and-prepare-upstream-native-modules.yml
@@ -35,7 +35,7 @@ jobs:
         run: sudo apt-get install -y libkrb5-dev
       - run: npm install --omit=optional
       - name: Set Electron Major version in env
-        run: echo "ELECTRON_MAJOR_VERSION=$(node --eval='const semver = require(\"semver\"); const electron = require(\"electron/package.json\"); console.log(semver.major(electron.version))')" >> $GITHUB_ENV
+        run: echo "ELECTRON_MAJOR_VERSION=$(node get-electron-major-version.js)" >> $GITHUB_ENV
       - run: npm run prepare
       - name: Upload list of modules to build
         uses: actions/upload-artifact@v3

diff --git a/.github/workflows/linux-build-prebuilds.yml b/.github/workflows/linux-build-prebuilds.yml
@@ -19,7 +19,7 @@ jobs:
       - name: Install toolkit
         run: npm ci
       - name: Set Electron Major version in env
-        run: echo "ELECTRON_MAJOR_VERSION=$(node --eval='const semver = require(\"semver\"); const electron = require(\"electron/package.json\"); console.log(semver.major(electron.version))')" >> $GITHUB_ENV
+        run: echo "ELECTRON_MAJOR_VERSION=$(node get-electron-major-version.js)" >> $GITHUB_ENV
       - name: Download artifact
         id: download-artifact
         uses: dawidd6/action-download-artifact@v2

diff --git a/.github/workflows/macos-intel-build-prebuilds.yml b/.github/workflows/macos-intel-build-prebuilds.yml
@@ -21,7 +21,7 @@ jobs:
       - name: Install toolkit
         run: npm ci
       - name: Set Electron Major version in env
-        run: echo "ELECTRON_MAJOR_VERSION=$(node --eval='const semver = require(\"semver\"); const electron = require(\"electron/package.json\"); console.log(semver.major(electron.version))')" >> $GITHUB_ENV
+        run: echo "ELECTRON_MAJOR_VERSION=$(node get-electron-major-version.js)" >> $GITHUB_ENV
       - name: Download artifact
         id: download-artifact
         uses: dawidd6/action-download-artifact@v2

diff --git a/.github/workflows/windows-intel-build-prebuilds.yml b/.github/workflows/windows-intel-build-prebuilds.yml
@@ -25,7 +25,7 @@ jobs:
       - name: Install tookit dependencies
         run: npm ci
       - name: Set Electron Major version in env
-        run: echo "ELECTRON_MAJOR_VERSION=$(node --eval='const semver = require(\"semver\"); const electron = require(\"electron/package.json\"); console.log(semver.major(electron.version))')" >> $GITHUB_ENV
+        run: echo "ELECTRON_MAJOR_VERSION=$(node get-electron-major-version.js)" >> $GITHUB_ENV
       - name: Download artifact
         id: download-artifact
         uses: dawidd6/action-download-artifact@v2