Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCK-8102: External table options #152

Merged
merged 6 commits into from
Sep 24, 2024
Merged

HCK-8102: External table options #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0453ebd
fix: normalized dependencies for 'external', 'iceberg', 'dynamic' and…
chulanovskyi-bs Sep 23, 2024
6731e19
fix: pass 'iceberg', 'dynamic' and 'transient' table options to scrip…
chulanovskyi-bs Sep 23, 2024
c3181e8
chore: refactored approach of adding space at the beginning of the st…
chulanovskyi-bs Sep 23, 2024
0ff0938
fix: pass missing parameters to a template
chulanovskyi-bs Sep 23, 2024
5564a93
fix: pass missing parameters to an "external" table template
chulanovskyi-bs Sep 24, 2024
11db056
Merge branch 'develop' into fix/HCK-8102-iceberg
chulanovskyi-bs Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forward_engineering/configs/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module.exports = {
createAsSelect: 'CREATE TABLE IF NOT EXISTS ${name} AS ${selectStatement}${tableOptions};\n',

createExternalTable:
'CREATE EXTERNAL TABLE IF NOT EXISTS \n' +
'CREATE${orReplace} EXTERNAL TABLE${tableIfNotExists}\n' +
'\t${name} (\n' +
'\t\t${column_definitions}${out_of_line_constraints}\n' +
'\t)${tableOptions};\n',
Expand Down
3 changes: 2 additions & 1 deletion forward_engineering/ddlProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ module.exports = (baseProvider, options, app) => {
],
comment,
),

orReplace,
tableIfNotExists,
column_definitions: columnDefinitions,
out_of_line_constraints: getOutOfLineConstraints(
isActivated,
Expand Down