Skip to content

Commit

Permalink
HCK-8277: remove column definitions from script for iceberg table wit…
Browse files Browse the repository at this point in the history
…h external catalog
  • Loading branch information
serhii-filonenko committed Nov 15, 2024
1 parent 7000b51 commit c032f54
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion forward_engineering/ddlProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,14 +347,17 @@ module.exports = (baseProvider, options, app) => {
});

if (tableData.dynamic || tableData.iceberg) {
const isExternalCatalog = tableData.iceberg && tableData.tableExtraProps.catalogMgmt === 'external';
const tableColumnDefinitions = isExternalCatalog ? '' : columnDefinitions;

const tableExtraOptions = getTableExtraProps({
tableData,
tagsStatement,
clusterKeys,
comment,
dataRetentionTime,
copyGrants,
columnDefinitions,
columnDefinitions: tableColumnDefinitions,
});

return assignTemplates(templates.createDynamicTable, {
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c032f54

Please sign in to comment.