HCK-8277: remove column definitions from script for iceberg table wit…

…h external catalog (#161)
hackolade · Nov 15, 2024 · b9d9820 · b9d9820
1 parent 7000b51
commit b9d9820
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/forward_engineering/ddlProvider.js b/forward_engineering/ddlProvider.js
@@ -347,14 +347,17 @@ module.exports = (baseProvider, options, app) => {
 			});
 
 			if (tableData.dynamic || tableData.iceberg) {
+				const isExternalCatalog = tableData.iceberg && tableData.tableExtraProps.catalogMgmt === 'external';
+				const tableColumnDefinitions = isExternalCatalog ? '' : columnDefinitions;
+
 				const tableExtraOptions = getTableExtraProps({
 					tableData,
 					tagsStatement,
 					clusterKeys,
 					comment,
 					dataRetentionTime,
 					copyGrants,
-					columnDefinitions,
+					columnDefinitions: tableColumnDefinitions,
 				});
 
 				return assignTemplates(templates.createDynamicTable, {

diff --git a/package-lock.json b/package-lock.json