-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCK-8816: queries optimization #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olved some sonarlint remarks
thomas-jakemeyn
approved these changes
Nov 21, 2024
… reducing the in-place complexity, splitting it to smaller pieces
…K-8816-optimize-queries
…, `getViewsIndexes`
…atabaseCheckConstraints`, `getTableKeyConstraints`, `getDatabaseXmlSchemaCollection`
bigorn0
reviewed
Nov 26, 2024
thomas-jakemeyn
requested changes
Nov 26, 2024
@thomas-jakemeyn @bigorn0 Finalized the PR (at last 😅). The tests are passing, please check and proceed with the merge if ok |
thomas-jakemeyn
approved these changes
Dec 5, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical details
WHERE
clause specifying the previously selected schemas and tables (expanddatabaseService.js
diff to investigate the highlighted part):is_memory_optimized
tables)connectionState
into aClientManager
classComparison metrics between
WHERE
andWITH
approachesWHERE - https://www.brentozar.com/pastetheplan/?id=S1HElHm7yx
WITH - https://www.brentozar.com/pastetheplan/?id=Hkon1BX7Jx