fix SQL Terminator procedure

hackolade · Jul 5, 2022 · d088ec0 · d088ec0
1 parent 729f0f3
commit d088ec0
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/reverse_engineering/helpers/oracleHelper.js b/reverse_engineering/helpers/oracleHelper.js
@@ -495,7 +495,9 @@ const splitEntityNames = names => {
 };
 
 const setSQLTerminator = () => {
-	return execute(`EXECUTE DBMS_METADATA.SET_TRANSFORM_PARAM(DBMS_METADATA.SESSION_TRANSFORM,'SQLTERMINATOR', TRUE)`);
+	return execute(`BEGIN
+		DBMS_METADATA.SET_TRANSFORM_PARAM(DBMS_METADATA.SESSION_TRANSFORM,'SQLTERMINATOR', TRUE);
+	END;`);
 }
 
 const getDDL = async (tableName, schema, logger) => {
@@ -548,12 +550,12 @@ const getDDL = async (tableName, schema, logger) => {
 				: '';
 			const columnComments = _.map(queryObj.columnComments, 
 				c => `COMMENT ON COLUMN ${escapeName(schema)}.${escapeName(tableName)}.${escapeName(c.name)}  IS ${escapeComment(c.comment)};`);
-			const ddl = `${queryObj.tableDDL};
-				${_.join(queryObj.indexDDLs, ';\n')};
+			const ddl = `${queryObj.tableDDL}
+				${_.join(queryObj.indexDDLs, '\n')}
 				${tableComment}\n
 				${_.join(columnComments, '\n')}`;
 			return {
-				ddl: ddl.replaceAll(/[;]{2,}/g, ';'),
+				ddl: ddl,
 				jsonColumns: queryObj.jsonColumns,
 				countOfRecords: queryObj.countOfRecords,
 			};