Fix: wrongly removed dependency between identifier type and service n…

…ame (#133) * fix: wrongly removed dependency between identifier type and service name * be explicit on the combination to re-enable service name using basic method and service identifier service name
hackolade · Sep 21, 2024 · 65ea7f9 · 65ea7f9
1 parent febd83b
commit 65ea7f9
Showing 1 changed file with 20 additions and 2 deletions.
diff --git a/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json b/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json
@@ -140,8 +140,26 @@
 				"description": "Specify the service name of the Oracle Instance",
 				"inputType": "text",
 				"dependency": {
-					"key": "connectionMethod",
-					"value": ["TNS"]
+					"type": "or",
+					"values": [
+						{
+							"key": "connectionMethod",
+							"value": ["TNS"]
+						},
+						{
+							"type": "and",
+							"values": [
+								{
+									"key": "connectionMethod",
+									"value": ["Basic"]
+								},
+								{
+									"key": "identifierType",
+									"value": ["serviceName"]
+								}
+							]
+						}
+					]
 				}
 			},
 			{