-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCK-8896: Code improvements #242
Conversation
Quality Gate passedIssues Measures |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
||
module.exports = app => { | ||
const { assignTemplates } = app.require('@hackolade/ddl-fe-utils'); | ||
const _ = app.require('lodash'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nightlngale ideally getting deps like this should be migrated to direct deps in the plugin when possible :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigorn0 I couldn’t agree more. But here I was trying to touch a small part of code related only to "Create view" script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nightlngale that's true in general that we want to limit the impacted surface but for such tech debt and given how often we go into plugins code I think the opposite: If we don't do our sanity/cleanup changes along the way when we are adapting plugins then we NEVER get the chance to actually tackle such debt :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Ugo it's a good opportunity to fix it. But I would propose fixing it in a separate PR. @Nightlngale could you please create PR with this tech improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigorn0 @VitaliiBedletskyi yes, I will add this improvement in scope of the separate PR
Content