Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCK-7856: FE DDL of CREATE VIEW should include column_list with column comment #241

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

Nightlngale
Copy link
Contributor

@Nightlngale Nightlngale commented Nov 25, 2024

TaskHCK-7856 [Pepsi] Databricks FE DDL of CREATE VIEW should include column_list with column comment

Technical details

  • change concatenation to template.

@Nightlngale Nightlngale self-assigned this Nov 25, 2024
@Nightlngale Nightlngale marked this pull request as ready for review November 25, 2024 09:28
Comment on lines +149 to +150
global: isGlobal ? 'GLOBAL ' : '',
temporary: isTemporary ? 'TEMPORARY ' : '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct to assume that if there will be no orReplace applied, the global will be concatenated in the resulted statement, for example, like the following?
CREATEGLOBAL ...

@Nightlngale Nightlngale enabled auto-merge (squash) November 25, 2024 16:16
@Nightlngale Nightlngale merged commit dbd967d into develop Nov 25, 2024
8 checks passed
@Nightlngale Nightlngale deleted the HCK-7856 branch November 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants