Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCK-7932: fix FE of deactivated attributes in delta model #227

Merged
merged 2 commits into from
Sep 10, 2024
Merged

HCK-7932: fix FE of deactivated attributes in delta model #227

merged 2 commits into from
Sep 10, 2024

Conversation

Vitalii4as
Copy link
Contributor

@Vitalii4as Vitalii4as commented Sep 9, 2024 •
edited by github-actions bot
Loading

Sub-taskHCK-7932 Deactivated attributes should be commented out in Alter script

Content

isParentActivated wasn't passed as an argument to the function, therefore it was falsy, and the function didn't commented out the column statement

@Vitalii4as Vitalii4as self-assigned this Sep 9, 2024
@VitaliiBedletskyi VitaliiBedletskyi enabled auto-merge (squash) September 9, 2024 13:11
@Vitalii4as Vitalii4as disabled auto-merge September 9, 2024 14:50
@Vitalii4as Vitalii4as enabled auto-merge (squash) September 9, 2024 14:50
@thomas-jakemeyn thomas-jakemeyn merged commit b26f78e into develop Sep 10, 2024
@thomas-jakemeyn thomas-jakemeyn deleted the fix/HCK-7932 branch September 10, 2024 07:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliiBedletskyi VitaliiBedletskyi VitaliiBedletskyi approved these changes

Assignees

@Vitalii4as Vitalii4as

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vitalii4as @VitaliiBedletskyi @thomas-jakemeyn